[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Apr 18 08:44:19 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8762 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/8762/5/include/asterisk/frame.h
File include/asterisk/frame.h:

https://gerrit.asterisk.org/#/c/8762/5/include/asterisk/frame.h@131
PS5, Line 131: 	/*! RTCP feedback (the subclass will contain the payload type) */
             : 	AST_FRAME_RTCP,
> Did you include this to keep it in sync with 15 and up?
Yes.  Note the comment describing this enum.  IAX2 sends these values out on the wire.



-- 
To view, visit https://gerrit.asterisk.org/8762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 13:44:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180418/0dda647d/attachment.html>


More information about the asterisk-code-review mailing list