[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8762 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.asterisk.org/#/c/8762/4/main/bridge_channel.c
File main/bridge_channel.c:

https://gerrit.asterisk.org/#/c/8762/4/main/bridge_channel.c@2376
PS4, Line 2376: 		ast_sendtext_data(bridge_channel->chan, (struct ast_msg_data *)fr->data.ptr);
> Since you have assigned msg to be fr->data.ptr it seems like you should use
Done


https://gerrit.asterisk.org/#/c/8762/4/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4897
PS4, Line 4897: 		if (body_len == 1) {
              : 
              : 		}
> ????
Done


https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4923
PS4, Line 4923: 		/* Send the body of an enhanced message to a channel driver that supports only a char str */
              : 		ast_debug(1, "Sending TEXT to %s: %s\n", ast_channel_name(chan), body);
              : 		res = ast_channel_tech(chan)->send_text(chan, body);
> Need the same text/plain check here for legacy.
Done


https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4944
PS4, Line 4944: 			.value = S_OR((char *)text, ""),
              : 		}
              : 	};
              : 
              : 	if (ast_strlen_zero(text)) {
> The S_OR() isn't needed anymore with the ast_strlen_zero() exit check resto
Done



-- 
To view, visit https://gerrit.asterisk.org/8762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 16:15:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180417/c56663a6/attachment.html>