[Asterisk-code-review] streams: Add string metadata capability (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8781 )

Change subject: streams: Add string metadata capability
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8781/1/include/asterisk/stream.h
File include/asterisk/stream.h:

https://gerrit.asterisk.org/#/c/8781/1/include/asterisk/stream.h@87
PS1, Line 87: 	AST_STREAM_METADATA_TRACK_LABEL = 0,
> Is there a reason you made it a requirement that any added metadata
 > has to be added here instead of making it generic using a name
 > instead?

It's easier to search rather than doing string compares on keys.  Easy enough to change to strings though if you'd prefer.



-- 
To view, visit https://gerrit.asterisk.org/8781
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7473aa4b374d7ab53046c20e321037ba9a56863
Gerrit-Change-Number: 8781
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 12:39:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180416/3aa1b437/attachment.html>