[Asterisk-code-review] res rtp asterisk: Add support for receiving and handling NAC... (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8773 )

Change subject: res_rtp_asterisk: Add support for receiving and handling NACK requests.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5267
PS2, Line 5267: 	for (j = 3; j < length; j++) {
> On further investigation I think the FCI information starts at 1.
Oh nevermind, I see what you did.


https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5702
PS2, Line 5702: 		case RTCP_PT_FUR:
              : 			/* Handle RTCP FUR as FIR by setting the format to 4 */
              : 			rc = AST_RTP_RTCP_FMT_FIR;
This needs to go after RTCP_PT_RTPFB so it falls through as it did previously.



-- 
To view, visit https://gerrit.asterisk.org/8773
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f7f124af3b9d5d2fd9cffc6ba8cb48a6fff06ec
Gerrit-Change-Number: 8773
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 11:59:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180416/e48ba0d4/attachment.html>