[Asterisk-code-review] utils: Add ast assert else (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Apr 13 16:36:32 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8778 )

Change subject: utils:  Add ast_assert_else
......................................................................


Patch Set 1: Code-Review-1

I don't like this patch at all.

Why is this even needed?  We have many cases where we have to do cleanups to exit a function early that trying to bury it under a macro just makes the syntax non-standard.  It also can break tools because of the non-standard syntax.


-- 
To view, visit https://gerrit.asterisk.org/8778
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0003844affeab550d5ff5bca7aa7cf8a559b873e
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 21:36:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180413/bb036389/attachment.html>


More information about the asterisk-code-review mailing list