[Asterisk-code-review] utils: Add ast assert else (asterisk[15])

Corey Farrell asteriskteam at digium.com
Fri Apr 13 15:52:07 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8779 )

Change subject: utils:  Add ast_assert_else
......................................................................


Patch Set 2: Code-Review-1

I'm just on my phone and can't comment directly on the line but this causes multiple evaluation of 'a' in devmode on failure.  Should use _ast_asset(0, #a, ...) instead of ast_assert.


-- 
To view, visit https://gerrit.asterisk.org/8779
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I0003844affeab550d5ff5bca7aa7cf8a559b873e
Gerrit-Change-Number: 8779
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 13 Apr 2018 20:52:07 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180413/161919b3/attachment.html>


More information about the asterisk-code-review mailing list