[Asterisk-code-review] cdr mysql: Compile error because MYSQL PORT definition is mi... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8767 )

Change subject: cdr_mysql: Compile error because MYSQL_PORT definition is missing
......................................................................


Patch Set 2:

> > Patch Set 2:
 > >
 > > > MariaDB stopped use of MYSQL_PORT declaration
 > >
 > > Incorrect. https://github.com/MariaDB/server/blob/10.3/include/mysql.h
 > 
 > Sean, Look my Debian case (Corey Farrell found same case in Fedora)
 > 
 > /usr/include/mysql# cat mysql.h  | grep -i version\.h
 > #include "mariadb_version.h"
 > /usr/include/mysql# cat mariadb_version.h | grep PORT
 > #define MARIADB_PORT	        	3306
 > /usr/include/mysql# dpkg -S /usr/include/mysql/mysql.h
 > libmariadb-dev: /usr/include/mysql/mysql.h
 > /usr/include/mysql# dpkg -S /usr/include/mysql/mariadb_version.h
 > libmariadb-dev: /usr/include/mysql/mariadb_version.h
 > /usr/include/mysql# apt-cache show libmariadb-dev
 > Package: libmariadb-dev
 > Source: mariadb-10.2
 > Version: 10.2.14+maria~stretch
 > Architecture: amd64
 > Maintainer: MariaDB Developers <maria-developers at lists.launchpad.net>
 > Installed-Size: 5109

Yes, I didn't consider that package maintainers would arbitrarily break the includes.


-- 
To view, visit https://gerrit.asterisk.org/8767
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8767
Gerrit-PatchSet: 2
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 15:16:55 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180413/aca24b38/attachment.html>