[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8762 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/8762/2/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4888
PS2, Line 4888: 	if (ast_channel_tech(chan)->write_text
> For channel drivers that only support T.140 or the old send_text
 > callback we should discard sending any messages that are not
 > text/plain content and report failure.

I'm not sure that's something we should enforce.  I can't find anything in T.140 that says that text HAS to be "plain".


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4897
PS2, Line 4897: 		f.datalen = body_len;
> Probably should not send empty text messages over T.140.

Again, nothing in T.140 says an empty message is invalid and RFC4103 does specify that an empty T.140 block is used for "idle".


https://gerrit.asterisk.org/#/c/8762/2/res/res_pjsip_messaging.c
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/8762/2/res/res_pjsip_messaging.c@64
PS2, Line 64: static enum pjsip_status_code check_content_type(const pjsip_rx_data *rdata)
> This allows any MESSAGE content type even for out-of-dialog
 > MESSAGEs.  We still only send out-of-dialog text/plain content so
 > we need the old version for module_on_rx_request() and this new
 > version for incoming_in_dialog_request().
 > 
 > Also you did not update the function doxygen comment.

There's no reason out of dialog messages should be limited to text/plain.



-- 
To view, visit https://gerrit.asterisk.org/8762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 13:00:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180413/00ae96f8/attachment.html>