[Asterisk-code-review] * cdr mysql: Compile error because is misssing MYSQL PORT de... (asterisk[15])

Evandro César Arruda asteriskteam at digium.com
Wed Apr 11 14:11:44 CDT 2018


Evandro César Arruda has posted comments on this change. ( https://gerrit.asterisk.org/8708 )

Change subject: * cdr_mysql: Compile error because is misssing MYSQL_PORT definition
......................................................................


Patch Set 4:

> Restore version 3

Sean Bright are right about mysql.h... But MariaDB started use of MARIADB_PORT definition instead of MYSQL_PORT definition, we will have same problem on fedora tree and others like Corey told.

If don't have MYSQL_PORT and MARIADB_PORT this system don't have mysql client installed.

What you thing about it? See.. I commited better approach, because ignoring MARIADB_PORT definition we may have problem in future.


-- 
To view, visit https://gerrit.asterisk.org/8708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 4
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 19:11:44 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/faf05709/attachment.html>


More information about the asterisk-code-review mailing list