[Asterisk-code-review] cdr mysql: Compile error because MYSQL PORT definition is mi... (asterisk[13])

[Evandro César Arruda]

Evandro César Arruda has posted comments on this change. ( https://gerrit.asterisk.org/8767 )

Change subject: cdr_mysql: Compile error because MYSQL_PORT definition is missing
......................................................................


Patch Set 1:

> Sorry, I am just seeing the comments from the other reviews (the
 > reviews were not properly linked).
 > 
 > I still am not sure why this change is necessary as the define is
 > there, even in mariadb.

In this case you are wrong...

/usr/include/mysql# cat mysql.h | grep  \_version | grep include
#include "mariadb_version.h"
/usr/include/mysql# cat mariadb_version.h | grep 3306
#define MARIADB_PORT	        	3306

MariaDB stopped use of MYSQL_PORT declaration, or leave patch just checking MYSQL_PORT or create some check about MYSQL_PORT and MARIADB_PORT and set correct MYSQL_PORT value. What you think about it?


-- 
To view, visit https://gerrit.asterisk.org/8767
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8767
Gerrit-PatchSet: 1
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 18:39:53 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/17d76c3f/attachment.html>