[Asterisk-code-review] app sendtext: Enhance SendText to support Enhanced Messaging (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8764 )

Change subject: app_sendtext:  Enhance SendText to support Enhanced Messaging
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c
File apps/app_sendtext.c:

https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@54
PS2, Line 54: 			<note><para><literal>current channel</literal> could be the caller or callee depending
            : 			on the context in which this application is called.</para></note>
This note still needs to be removed.


https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@213
PS2, Line 213: 		msg_type = "NONE";
Beware of this being a redundant set when fixing the below finding.


https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@222
PS2, Line 222: 	pbx_builtin_setvar_helper(chan, "SENDTEXTTYPE", msg_type);
             : 	pbx_builtin_setvar_helper(chan, "SENDTEXTSTATUS", status);
You now have two cleanup code paths that have status, msg_type, or both not set.

You might as well set the initial values on declaration and only change them when needed:

const char *status = "FAILURE";
const char *msg_type = "NONE";



-- 
To view, visit https://gerrit.asterisk.org/8764
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I648b4574478119f95de09d9f08e9595831b02830
Gerrit-Change-Number: 8764
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 15:56:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/e26bedce/attachment-0001.html>