[Asterisk-code-review] chan dahdi: Configurable dialed digit timeouts (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8637 )

Change subject: chan_dahdi: Configurable dialed digit timeouts
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/8637/1/UPGRADE.txt
File UPGRADE.txt:

https://gerrit.asterisk.org/#/c/8637/1/UPGRADE.txt@53
PS1, Line 53: chan_dahdi:
            :  - Timeouts for reading digits from analog phones are now configurable in
            :    chan_dahdi.conf: firstdigit_timeout, gendigit_timeout, matchdigit_timeout.
Should put this in the Asterisk 16 section of CHANGES also.


https://gerrit.asterisk.org/#/c/8637/1/channels/chan_dahdi.c
File channels/chan_dahdi.c:

https://gerrit.asterisk.org/#/c/8637/1/channels/chan_dahdi.c@557
PS1, Line 557: #define DEFAULT_FIRST_DIGIT_TIMEOUT	16000
             : #define DEFAULT_GEN_DIGIT_TIMEOUT	8000
             : #define DEFAULT_MATCH_DIGIT_TIMEOUT	3000
Move these defines into sig_analog.h so both chan_dahdi.c and sig_analog.c will have access to the defines.

Should prefix the defines with ANALOG_ like nearly everything else in sig_analog.h and add doxygen comments per below:

/*! \brief Default time in ms for first digit (FXO logic) */
#define ANALOG_DEFAULT_FIRST_DIGIT_TIMEOUT	16000
/*! \brief Default time in ms to wait for following digits (FXO logic) */
#define ANALOG_DEFAULT_GEN_DIGIT_TIMEOUT	8000
/*! \brief Default time in ms to wait for an extra digit, if there is an ambiguous match */
#define ANALOG_DEFAULT_MATCH_DIGIT_TIMEOUT	3000


https://gerrit.asterisk.org/#/c/8637/1/channels/chan_dahdi.c@3337
PS1, Line 3337: get_pvt_field_callback(int, firstdigit_timeout, 0);
              : get_pvt_field_callback(int, matchdigit_timeout, 0);
              : get_pvt_field_callback(int, gendigit_timeout, 0);
Instead of zero, the default value defines should be used.


https://gerrit.asterisk.org/#/c/8637/1/channels/sig_analog.c
File channels/sig_analog.c:

https://gerrit.asterisk.org/#/c/8637/1/channels/sig_analog.c@227
PS1, Line 227: analog_get_field_callback(int, firstdigit_timeout, 0);
             : analog_get_field_callback(int, matchdigit_timeout, 0);
             : analog_get_field_callback(int, gendigit_timeout, 0);
Instead of zero, the default value defines should be used.



-- 
To view, visit https://gerrit.asterisk.org/8637
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib728fa900a4f6ae56d1ed810aba61b6593fb7213
Gerrit-Change-Number: 8637
Gerrit-PatchSet: 1
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 16:36:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180410/a4fd1c7a/attachment.html>