[Asterisk-code-review] res pjsip session: Rewrite o= with external media address. (asterisk[master])

[Christian Savinovich]

Christian Savinovich has uploaded this change for review. ( https://gerrit.asterisk.org/8761


Change subject: res_pjsip_session: Rewrite o= with external_media_address.
......................................................................

res_pjsip_session: Rewrite o= with external_media_address.

This change fixes an issue that was addressed but not
adequately fixed in ASTERISK-27341.
It now correctly appends the external IP address on the
o= line of the SDP packet

ASTERISK-27614 #close

Change-Id: I84f3360f3606b8c4e8d161edb228799ec0b8a302
---
M res/res_pjsip_session.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/61/8761/1

diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index d13b372..49ab875 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -4153,7 +4153,7 @@
 		if (ast_sip_transport_is_local(transport_state, &our_sdp_addr) || !transport_state->localnet) {
 			ast_debug(5, "Setting external media address to %s\n", ast_sockaddr_stringify_host(&transport_state->external_media_address));
 			pj_strdup2(tdata->pool, &sdp->conn->addr, ast_sockaddr_stringify_host(&transport_state->external_media_address));
-			pj_strdup2(tdata->pool, &sdp->origin.addr, transport->external_media_address);
+			pj_strassign(&sdp->origin.addr, &sdp->conn->addr);
 		}
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/8761
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84f3360f3606b8c4e8d161edb228799ec0b8a302
Gerrit-Change-Number: 8761
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180410/18766940/attachment.html>