[Asterisk-code-review] res rtp asterisk: Queue video update on picture loss indicat... (asterisk[15])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/8733 )

Change subject: res_rtp_asterisk: Queue video update on picture loss indication.
......................................................................

res_rtp_asterisk: Queue video update on picture loss indication.

The previous payload specific feedback handling was very single
minded in that it just assumed everything should trigger a video
update. This was changed but the handling of picture loss indication
was not added. The result was that video may not flow. This change
adds it explicitly in.

Change-Id: I1894be02e39ee10a0af841b5a1dca5f0ec7d60b6
---
M include/asterisk/rtp_engine.h
M res/res_rtp_asterisk.c
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Matthew Fredrickson: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/include/asterisk/rtp_engine.h b/include/asterisk/rtp_engine.h
index b552948..8f044ce 100644
--- a/include/asterisk/rtp_engine.h
+++ b/include/asterisk/rtp_engine.h
@@ -296,6 +296,8 @@
 #define AST_RTP_RTCP_PSFB    206
 
 /* Common RTCP feedback message types */
+/*! Picture loss indication (From RFC4585) */
+#define AST_RTP_RTCP_FMT_PLI	1
 /*! Full INTRA-frame Request (From RFC5104) */
 #define AST_RTP_RTCP_FMT_FIR	4
 /*! REMB Information (From draft-alvestrand-rmcat-remb-03) */
diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index b010f6c..c87e6fb 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -5525,10 +5525,11 @@
 			f = &transport_rtp->f;
 			break;
 		case RTCP_PT_FUR:
-		/* Handle RTCP FUR as FIR by setting the format to 4 */
+			/* Handle RTCP FUR as FIR by setting the format to 4 */
 			rc = AST_RTP_RTCP_FMT_FIR;
 		case RTCP_PT_PSFB:
 			switch (rc) {
+			case AST_RTP_RTCP_FMT_PLI:
 			case AST_RTP_RTCP_FMT_FIR:
 				if (rtcp_debug_test_addr(addr)) {
 					ast_verbose("Received an RTCP Fast Update Request\n");

-- 
To view, visit https://gerrit.asterisk.org/8733
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I1894be02e39ee10a0af841b5a1dca5f0ec7d60b6
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180409/30b799b6/attachment.html>