[Asterisk-code-review] Build System: Enable python3 compatibility. (asterisk[15])

Corey Farrell asteriskteam at digium.com
Mon Apr 9 09:09:57 CDT 2018


Hello Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8645

to look at the new patch set (#4).

Change subject: Build System: Enable python3 compatibility.
......................................................................

Build System: Enable python3 compatibility.

* Consistently use spaces in rest-api-templates/asterisk_processor.py.
* Exclude third-party from docs/full-en_US.xml.
* Add docs/full-en_US.xml to .gitignore.
* Use list() to convert python3 view.
* Use python3 print function.
* Replace cmp() with equivalent equation.
* Replace reference to out of scope subtype variable with name
  parameter.
* Use unescaping triple bracket notation in mustache templates where
  needed.  This causes behavior of Python2 to be maintained when using
  Python3.
* Fix references to has_websocket / is_websocket in
  res_ari_resource.c.mustache.
* Update calculation of has_websocket to use any().
* Use unicode mode for writing output file in transform.py.
* Replace 'from swagger_model import *' with explicit import of required
  symbols.

I have not tested spandspflow2pcap.py or voicemailpwcheck.py, only the
print syntax has been fixed.

Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33
---
M Makefile
M contrib/scripts/refcounter.py
M contrib/scripts/spandspflow2pcap.py
M contrib/scripts/voicemailpwcheck.py
M doc/.gitignore
M rest-api-templates/api.wiki.mustache
M rest-api-templates/ari_resource.h.mustache
M rest-api-templates/asterisk_processor.py
M rest-api-templates/make_ari_stubs.py
M rest-api-templates/res_ari_resource.c.mustache
M rest-api-templates/swagger_model.py
M rest-api-templates/transform.py
12 files changed, 49 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/45/8645/4
-- 
To view, visit https://gerrit.asterisk.org/8645
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33
Gerrit-Change-Number: 8645
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180409/dc2aa6df/attachment.html>


More information about the asterisk-code-review mailing list