[Asterisk-code-review] * cdr mysql: Compile error because is misssing MYSQL PORT de... (asterisk[15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8708 )

Change subject: * cdr_mysql: Compile error because is misssing MYSQL_PORT definition
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > > Fedora patches this by adding an include to mysql/mariadb_version.h
 > > and using MARIADB_PORT instead of MYSQL_PORT.  Not sure it's
 > worth
 > > it to detect that header in the configure scripts and use
 > `#define
 > > MYSQL_PORT MARIADB_PORT`?
 > >
 > > I really have no opinion on this just pointing out what Fedora
 > > does.
 > 
 > Very nice information, thanks. Well, it's confirm my research. It
 > isn't on MySQL/MariaDB tree... we will have the same problem with
 > other linux distros (like Debian that i use).
 > 
 > I could change my patch to support both case (it will increase a
 > few 'ifs' and lines of code, but ok...) Is it ok for you? May i
 > proceed?

I'll defer to others.  I'm actually just working on building an EL7 RPM for Asterisk and noticed the patch (I'm starting from fedora SRPM).  I doubt MARIADB_PORT would ever be anything other than 3306 so this probably doesn't matter.


-- 
To view, visit https://gerrit.asterisk.org/8708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 2
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 13:50:15 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180409/960a4ed2/attachment-0001.html>