[Asterisk-code-review] Build System: Enable python3 compatibility. (asterisk[master])

Tzafrir Cohen asteriskteam at digium.com
Thu Apr 5 09:04:32 CDT 2018


Tzafrir Cohen has posted comments on this change. ( https://gerrit.asterisk.org/8641 )

Change subject: Build System: Enable python3 compatibility.
......................................................................


Patch Set 2:

I think you still missed some prints:

asterisk(review/corey_farrell/python3-compat)$ pyflakes3 contrib/
contrib/scripts/sip_to_pjsip/astconfigparser.py:448:40: invalid syntax
            print "Could not open file ", filename, " for reading"
                                       ^
contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:94:45: inconsistent use of tabs and spaces in indentation
		disallow = sip.get(section, 'disallow')[0]
		                                          ^
contrib/scripts/sip_to_pjsip/sip_to_pjsql.py:21:36: invalid syntax
        print "Could not open file ", filename, " for writing"
                                   ^
contrib/scripts/sip_to_pjsip/sqlconfigparser.py:64:25: invalid syntax
        except Exception,e:
                        ^
contrib/ast-db-manage/config/versions/28887f25a46f_create_queue_tables.py:32: 'alembic.context' imported but unused


-- 
To view, visit https://gerrit.asterisk.org/8641
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 14:04:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180405/612229d2/attachment.html>


More information about the asterisk-code-review mailing list