[Asterisk-code-review] rest api blind transfer tests fail due to unregistered contacts (testsuite[15])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8696 )

Change subject: rest_api blind transfer tests fail due to unregistered contacts
......................................................................

rest_api blind transfer tests fail due to unregistered contacts

Two tests rest_api/external_interaction/blind_transfer tests:

stasis_bridge_to_different_stasis_app
stasis_bridge_to_same_stasis_app

failed because pjsua accounts were not yet available to the transfer module.
This is because there is a race condition between registering of configured
accounts and initializing the transfer module. If the initialization happens
before receiving registers then then test fails due to missing accounts.

This patch makes affected tests just use static contacts instead of waiting
on registers since the test does not depend upon that. That way all pjsua
endpoints are always considered "ready" before the call to call_transfer
initialization.

Change-Id: Iab1a86a876f160753c74c261620fe383599742a4
---
M tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml
M tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml
index 257054d..11061ba 100644
--- a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml
+++ b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml
@@ -51,6 +51,8 @@
             bind: '127.0.0.1'
             bindport: '5062'
     accounts:
+        # Use static contacts due to race condition between 'reg_success' and
+        # 'call_transfer' method calls.
         -
             name: 'alice'
             username: 'alice'
@@ -58,12 +60,14 @@
             transport: 'local-ipv4-1'
             call_uri: 'sip:stasis at 127.0.0.1'
             transfer_uri: 'sip:1000 at 127.0.0.1'
+            register: False
         -
             name: 'bob'
             username: 'bob'
             domain: '127.0.0.1'
             transport: 'local-ipv4-2'
             call_uri: 'sip:stasis at 127.0.0.1'
+            register: False
 
 pluggable-config:
     # Upon kickoff channel entering Stasis app: create a bridge, don't add
diff --git a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml
index 5298b41..59fe408 100644
--- a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml
+++ b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml
@@ -47,6 +47,8 @@
             bind: '127.0.0.1'
             bindport: '5062'
     accounts:
+        # Use static contacts due to race condition between 'reg_success' and
+        # 'call_transfer' method calls.
         -
             name: 'alice'
             username: 'alice'
@@ -54,12 +56,14 @@
             transport: 'local-ipv4-1'
             call_uri: 'sip:stasis at 127.0.0.1'
             transfer_uri: 'sip:1000 at 127.0.0.1'
+            register: False
         -
             name: 'bob'
             username: 'bob'
             domain: '127.0.0.1'
             transport: 'local-ipv4-2'
             call_uri: 'sip:stasis at 127.0.0.1'
+            register: False
 
 pluggable-config:
     # Upon kickoff channel entering Stasis app: create a bridge, don't add

-- 
To view, visit https://gerrit.asterisk.org/8696
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab1a86a876f160753c74c261620fe383599742a4
Gerrit-Change-Number: 8696
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180402/88a9e3e3/attachment.html>