[Asterisk-code-review] sip tls register: test timing issues due to receive timeout ... (testsuite[master])

Jenkins2 asteriskteam at digium.com
Mon Apr 2 07:19:37 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8694 )

Change subject: sip_tls_register: test timing issues due to receive timeout being too low
......................................................................

sip_tls_register: test timing issues due to receive timeout being too low

The SIP/sip_tls_register test had a "recv_timeout" set on it of 1 second. This
sometimes caused the test to fail because on slower systems the response might
take slightly longer. Removed the timeout value as it's not really needed for
this test.

Change-Id: I05ba4aa19ed8884ac3c4b60eb894916c32d557ca
---
M tests/channels/SIP/sip_tls_register/run-test
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/SIP/sip_tls_register/run-test b/tests/channels/SIP/sip_tls_register/run-test
index 9db902f..41384e2 100755
--- a/tests/channels/SIP/sip_tls_register/run-test
+++ b/tests/channels/SIP/sip_tls_register/run-test
@@ -85,7 +85,6 @@
         scenario_def = {
             'scenario': 'register.xml',
             '-p': '5061',
-            '-recv_timeout': '1000',
             '-s': 'SIP/v4-in',
             '-t': 'ln',
             '-tls_cert': '%s/configs/keys/serverA.crt' % self.test_name,

-- 
To view, visit https://gerrit.asterisk.org/8694
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I05ba4aa19ed8884ac3c4b60eb894916c32d557ca
Gerrit-Change-Number: 8694
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180402/2f80a6be/attachment.html>


More information about the asterisk-code-review mailing list