[Asterisk-code-review] logger: Bring back ability to turn debug on by source file (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6618 )

Change subject: logger:  Bring back ability to  turn debug on by source file
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6618/2/include/asterisk/logger.h
File include/asterisk/logger.h:

https://gerrit.asterisk.org/#/c/6618/2/include/asterisk/logger.h@450
PS2, Line 450: 		|| (ast_opt_dbg_module && ((int)ast_debug_get_by_module(AST_MODULE) >= (level) \
             : 		|| (int)ast_debug_get_by_module(__FILE__) >= (level))))
nit: would you mind tweaking the formatting to make it easier to see that neither call to ast_debug_get_by_module is run unless ast_opt_dbg_module is true?  Maybe each call to ast_debug_get_by_module on a new line with an extra indent?



-- 
To view, visit https://gerrit.asterisk.org/6618
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc0af41837f3b1679dec7af21fa32cd1f7469f6e
Gerrit-Change-Number: 6618
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 17:10:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170928/502270aa/attachment.html>