[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[15])

George Joseph asteriskteam at digium.com
Thu Sep 28 08:37:27 CDT 2017


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/6616

to look at the new patch set (#2).

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................

bridge_softmix:  Forward TEXT frames

res_pjsip_messaging queues TEXT frames to the channel when it
receives an in-dialog MESSAGE from an endpoint and chan_pjsip will
send an MESSAGE when it gets a TEXT frame.  On a normal
point-to-point call, the frames are forwarded between the two
correctly.  bridge_softmix was not though so messages weren't
getting forwarded to conference bridge participants.

* bridge_softmix now forwards TEXT frames to all participants. It
also forwards the frame back to the sender as a confirmation and to
make client side development a little easier.  A channel datastore
indicating the display name of the message sender is created so the
channel driver can indicate that to the participants.  If we don't
do that, the text message will appear to come from the bridge.

* chan_pjsip now uses the originator name in the channel datastore
(if it exists) to set the From: display name on outgoing text
messages.

Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
---
M bridges/bridge_softmix.c
M bridges/bridge_softmix/include/bridge_softmix_internal.h
M channels/chan_pjsip.c
M include/asterisk/global_datastores.h
M main/asterisk.exports.in
M main/bridge_channel.c
M main/global_datastores.c
M res/res_pjsip_messaging.c
8 files changed, 119 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/16/6616/2
-- 
To view, visit https://gerrit.asterisk.org/6616
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 6616
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170928/0958465c/attachment.html>


More information about the asterisk-code-review mailing list