[Asterisk-code-review] res pjsip outbound publish.c: Fix misplaced parenthesis. (asterisk[14])

Jenkins2 asteriskteam at digium.com
Wed Sep 27 20:05:06 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6611 )

Change subject: res_pjsip_outbound_publish.c: Fix misplaced parenthesis.
......................................................................

res_pjsip_outbound_publish.c: Fix misplaced parenthesis.

The pjsip_publishc_init() call was referenced with a misplaced
parentheses.  As a result, outbound publication messages went out with an
expiration of 1 second.

ASTERISK-27298

Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08
---
M res/res_pjsip_outbound_publish.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/res/res_pjsip_outbound_publish.c b/res/res_pjsip_outbound_publish.c
index 18525bf..0fac8ad 100644
--- a/res/res_pjsip_outbound_publish.c
+++ b/res/res_pjsip_outbound_publish.c
@@ -986,7 +986,7 @@
 
 	pj_cstr(&event, publish->event);
 	if (pjsip_publishc_init(publisher->client, &event, &server_uri, &from_uri, &to_uri,
-				publish->expiration != PJ_SUCCESS)) {
+			publish->expiration) != PJ_SUCCESS) {
 		ast_log(LOG_ERROR, "Failed to initialize publishing client on outbound publish '%s'\n",
 			ast_sorcery_object_get_id(publish));
 		pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);

-- 
To view, visit https://gerrit.asterisk.org/6611
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: merged
Gerrit-Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08
Gerrit-Change-Number: 6611
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170927/562e59ee/attachment.html>


More information about the asterisk-code-review mailing list