[Asterisk-code-review] res pjsip session: Don't end session when receiving a 500 on... (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6568 )

Change subject: res_pjsip_session: Don't end session when receiving a 500 on a reinvite
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6568/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6568/1/res/res_pjsip_session.c@3471
PS1, Line 3471: 						if (tsx->status_code != 488 && tsx->status_code != 500) {
              : 							/* Other reinvite failures (except 488 and 500) result in destroying the session. */
> I thought we were going to try reverting to the previous state on any unsuc
The previous state shouldn't get touched unless a valid transaction occurred, thus nothing to revert.



-- 
To view, visit https://gerrit.asterisk.org/6568
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeedae86b8cb44b92d52c79046522ec5f0aff1d5
Gerrit-Change-Number: 6568
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 25 Sep 2017 14:18:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170925/c137d366/attachment.html>