[Asterisk-code-review] res pjsip session/BUNDLE: Handle no audio codecs on endpoint (asterisk[15])

George Joseph asteriskteam at digium.com
Fri Sep 22 07:01:51 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6555 )

Change subject: res_pjsip_session/BUNDLE:  Handle no audio codecs on endpoint
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6555/2/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6555/2/res/res_pjsip_session.c@1477
PS2, Line 1477: 					|| !ast_stream_get_formats(stream)) {
              : 					continue;
> What is the state of the stream in the case where no formats are
 > present on it?

Actually, we don't need that check anymore.  I'm going to remove it and just leave the check for REMOVED.



-- 
To view, visit https://gerrit.asterisk.org/6555
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic854eda54c95031e66b076ecfae3041d34daa692
Gerrit-Change-Number: 6555
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 12:01:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170922/3a471516/attachment-0001.html>


More information about the asterisk-code-review mailing list