[Asterisk-code-review] res pjsip session/BUNDLE: Handle no audio codecs on endpoint (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6555 )

Change subject: res_pjsip_session/BUNDLE:  Handle no audio codecs on endpoint
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6555/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6555/1/res/res_pjsip_session.c@647
PS1, Line 647: 				set_mid_and_bundle_group(session, session_media, sdp, remote_stream);
I don't think this is correct. The callback may need to know that it is part of a bundle group so it can get things appropriately (such as the transport). Setting it afterwards doesn't allow this information to exist, unless it is preserved through a subsequent renegotiation.



-- 
To view, visit https://gerrit.asterisk.org/6555
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic854eda54c95031e66b076ecfae3041d34daa692
Gerrit-Change-Number: 6555
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 14:57:18 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170921/3113fa89/attachment-0001.html>