[Asterisk-code-review] app queue: Only do announcement logic between ringing cycles (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Sep 21 05:02:24 CDT 2017


Joshua Colp has uploaded a new patch set (#2) to the change originally created by Stefan Engström. ( https://gerrit.asterisk.org/6506 )

Change subject: app_queue: Only do announcement logic between ringing cycles
......................................................................

app_queue: Only do announcement logic between ringing cycles

This patch reverts the change by patch 2263 from old reviewboard.
Note that reverting that 2263-patch still preserves the behaviour that
the commit log of the 2263-patch claimed to add. The reason for this is:

The function wait_for_answer is only called from try_calling which
in turn is only called from the main for loop in queue_exec, and
earlier in that loop we already check the things that's removed by
this patch. There's no need to check those things twice each loop
iteration, and I think the proper place to check it is before each
ringing cycle. By checking it in wait_for_answer, you allow the issue
explained in the jira - that the head caller hears announcements while
the agents' sip phones are actively ringing.

Reported-by: Stefan Engström
Tested-by: Stefan Engström
ASTERISK-27216 #close

Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0
---
M apps/app_queue.c
1 file changed, 4 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/06/6506/2
-- 
To view, visit https://gerrit.asterisk.org/6506
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0
Gerrit-Change-Number: 6506
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170921/47bd41f3/attachment.html>


More information about the asterisk-code-review mailing list