[Asterisk-code-review] res pjsip session: Check for removed stream state. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6464 )

Change subject: res_pjsip_session: Check for removed stream state.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6464/5/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6464/5/res/res_pjsip_session.c@1473
PS5, Line 1473: 					if (ast_format_cap_count(joint_cap)) {
              : 						ast_stream_set_formats(stream, joint_cap);
              : 					}
Heh.  joint_cap is leaked if it is empty.

if (!ast_format_cap_count(joint_cap)) {
  ao2_ref(joint_cap, -1);
  ast_stream_set_state(stream, AST_STREAM_STATE_REMOVED);
  continue;
}
ast_stream_set_formats(stream, joint_cap);



-- 
To view, visit https://gerrit.asterisk.org/6464
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86f8b65a4a26a60885b28b8b1a0b22e1b471d42
Gerrit-Change-Number: 6464
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 20 Sep 2017 15:55:04 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170920/5f0cc02a/attachment.html>