[Asterisk-code-review] app confbridge: Only create a channel that records audio. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Wed Sep 20 06:53:46 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6536 )

Change subject: app_confbridge: Only create a channel that records audio.
......................................................................

app_confbridge: Only create a channel that records audio.

This change makes it so that the conference recorder channel
that is created only contains audio formats and an audio stream.
This is because the underlying application used by ConfBridge to
record, MixMonitor, only allows recording audio.

Having additional streams (and in particular a video stream) can
result in clients needlessly renegotiating to add a video stream
that will never receive video.

Change-Id: I89d38aedc9205eca7741d5435e73e73bb9de97a0
---
M apps/confbridge/conf_chan_record.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/apps/confbridge/conf_chan_record.c b/apps/confbridge/conf_chan_record.c
index 5d3a7db..239fb91 100644
--- a/apps/confbridge/conf_chan_record.c
+++ b/apps/confbridge/conf_chan_record.c
@@ -65,7 +65,7 @@
 	if (!capabilities) {
 		return NULL;
 	}
-	ast_format_cap_append_by_type(capabilities, AST_MEDIA_TYPE_UNKNOWN);
+	ast_format_cap_append_by_type(capabilities, AST_MEDIA_TYPE_AUDIO);
 
 	chan = ast_channel_alloc(1, AST_STATE_UP, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0,
 		"CBRec/%s-%08x",

-- 
To view, visit https://gerrit.asterisk.org/6536
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89d38aedc9205eca7741d5435e73e73bb9de97a0
Gerrit-Change-Number: 6536
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170920/51b66121/attachment.html>


More information about the asterisk-code-review mailing list