[Asterisk-code-review] res srtp: lower log level of auth failures (asterisk[15])

Richard Mudgett asteriskteam at digium.com
Mon Sep 18 18:08:04 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6523 )

Change subject: res_srtp: lower log level of auth failures
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6523/1/res/res_srtp.c
File res/res_srtp.c:

https://gerrit.asterisk.org/#/c/6523/1/res/res_srtp.c@459
PS1, Line 459: 			ast_verb(2, "SRTCP unprotect failed on SSRC %d because of %s\n",
             : 				ast_rtp_instance_get_ssrc(srtp->rtp), srtp_errstr(res));
             : 		} else {
             : 			if ((srtp->warned >= 10) && !((srtp->warned - 10) % 150)) {
             : 				ast_verb(2, "SRTP unprotect failed on SSRC %d because of %s %d\n",
             : 					ast_rtp_instance_get_ssrc(srtp->rtp), srtp_errstr(res), srtp->warned);
ast_rtp_instance_get_ssrc() returns an unsigned int so you need to use %u in the format string.  Newer compilers give warnings about this mismatch.



-- 
To view, visit https://gerrit.asterisk.org/6523
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c98d46b711f56e08655abeb01c951ab8e8d7fa0
Gerrit-Change-Number: 6523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 18 Sep 2017 23:08:04 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170918/dbac2852/attachment.html>


More information about the asterisk-code-review mailing list