[Asterisk-code-review] bridge: Change participant SFU streams when source streams c... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6529 )

Change subject: bridge: Change participant SFU streams when source streams change.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6529/2/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/6529/2/bridges/bridge_softmix.c@509
PS2, Line 509: 		stream_clone = ast_stream_clone(stream, stream_clone_name);
             : 		if (!stream_clone) {
stream_clone_name needs to be freed right after calling ast_stream_clone().


https://gerrit.asterisk.org/#/c/6529/2/bridges/bridge_softmix.c@1024
PS2, Line 1024: 				ast_stream_topology_set_stream(dest, original_index, removed);
removed is leaked if ast_stream_topology_set_stream() fails.



-- 
To view, visit https://gerrit.asterisk.org/6529
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07
Gerrit-Change-Number: 6529
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 18 Sep 2017 22:15:38 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170918/a40488cf/attachment.html>