[Asterisk-code-review] bridge: Change participant SFU streams when source streams c... (asterisk[master])

Sean Bright asteriskteam at digium.com
Mon Sep 18 16:44:47 CDT 2017


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/6531 )

Change subject: bridge: Change participant SFU streams when source streams change.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6531/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/6531/1/bridges/bridge_softmix.c@503
PS1, Line 503: 		if (ast_asprintf(&stream_clone_name, "%s_%s_%s", SOFTBRIDGE_VIDEO_DEST_PREFIX,
stream_clone_name needs to be freed


https://gerrit.asterisk.org/#/c/6531/1/bridges/bridge_softmix.c@989
PS1, Line 989: 		const struct ast_stream_topology *source,
             : 	const struct ast_stream_topology *original)
Inconsistent leading whitespace



-- 
To view, visit https://gerrit.asterisk.org/6531
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07
Gerrit-Change-Number: 6531
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 18 Sep 2017 21:44:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170918/08d718df/attachment.html>


More information about the asterisk-code-review mailing list