[Asterisk-code-review] res pjsip: Add handling for incoming unsolicited MWI NOTIFY (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6480 )

Change subject: res_pjsip:  Add handling for incoming unsolicited MWI NOTIFY
......................................................................


Patch Set 3:

> Just a few questions, but will marking -1 so you see them:
 > 
 > Is this similar to chan_sip's "unsolicited_mailbox" options? If so
 > should we keep the name the same? Either way and if similar, should
 > this be added to the sip->pjsip conversion script?
 > 
 > One last thing. It might be worth updating the following wiki page
 > too: https://wiki.asterisk.org/wiki/display/AST/Message+Waiting+Indication

The new name is more descriptive and while the functionality is the same as chan_sip's unsolicited_mailbox, the actual values are different.  chan_sip expects just username and forces the context to be SIP_Remote where the chan_pjsip version requires a full username at context.

I'll update the wiki though.


-- 
To view, visit https://gerrit.asterisk.org/6480
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I08bae3d16e77af48fcccc2c936acce8fc0ef0f3c
Gerrit-Change-Number: 6480
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 14 Sep 2017 15:35:04 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170914/4262a17b/attachment.html>