[Asterisk-code-review] res pjsip: Add handling for incoming unsolicited MWI NOTIFY (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6480 )

Change subject: res_pjsip:  Add handling for incoming unsolicited MWI NOTIFY
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6480/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/6480/2/res/res_pjsip_pubsub.c@3485
PS2, Line 3485: 	summary = ast_calloc(1, sizeof(*summary));
Why do you calloc this versus passing one in?


https://gerrit.asterisk.org/#/c/6480/2/res/res_pjsip_pubsub.c@3517
PS2, Line 3517: 		ast_debug(1, "Endpoint not found in rdata (%p)\n", rdata);
I think these two debug messages aren't detailed enough. It should also specify it's for MWI handling.



-- 
To view, visit https://gerrit.asterisk.org/6480
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I08bae3d16e77af48fcccc2c936acce8fc0ef0f3c
Gerrit-Change-Number: 6480
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 13 Sep 2017 13:42:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170913/1e0f9791/attachment.html>