[Asterisk-code-review] res rtp asterisk.c: Make strict RTP learning more flexible. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6410 )

Change subject: res_rtp_asterisk.c: Make strict RTP learning more flexible.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6410/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6410/2/res/res_rtp_asterisk.c@5177
PS2, Line 5177: 				/* Not ready to accept the RTP stream candidate */
I think for debugging purposes having a different debug message for each of these cases would be useful.


https://gerrit.asterisk.org/#/c/6410/2/res/res_rtp_asterisk.c@5193
PS2, Line 5193: 		 * We should not allow a stream address change if the SSRC matches
              : 		 * once strictrtp learning is closed.  Any kind of address change
              : 		 * like this should have happened while we were in the learning
              : 		 * state.
Elaborate why this is the case.



-- 
To view, visit https://gerrit.asterisk.org/6410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2d3aa6e0f22906c25971e74f10027d96525f31c
Gerrit-Change-Number: 6410
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 13 Sep 2017 13:19:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170913/62d05b62/attachment.html>