[Asterisk-code-review] bridge native rtp : update peer channel's RTP when receiving... (asterisk[14])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6462 )

Change subject: bridge_native_rtp : update peer channel's RTP when receiving an ANSWER frame
......................................................................


Patch Set 1: Code-Review-1

I don't think this is the correct fix for this. The module itself is only currently written to work when both channels are answered. I think the native_rtp_bridge_capable function should be extended to also check the channel state and only return that the channel is capable if it is also answered. A comment should also be added to the join callback in ast_bridge_technology of bridge_technology.h stating that a channel may not be answered. Finally bridge_channel.c should trigger a reconfigured on the bridge when answer is received on a channel. That will allow it to transition into a native capable bridge if it can.


-- 
To view, visit https://gerrit.asterisk.org/6462
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: comment
Gerrit-Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df
Gerrit-Change-Number: 6462
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 11 Sep 2017 17:21:34 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170911/36b9c58f/attachment.html>