[Asterisk-code-review] res rtp asterisk: Drop RTCP packets less than 2 words in le... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6443 )

Change subject: res_rtp_asterisk:  Drop RTCP packets less than 2 words in length
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/6443/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6443/3/res/res_rtp_asterisk.c@4670
PS3, Line 4670: 		if (ast_rtp_instance_get_prop(instance, AST_RTP_PROPERTY_NAT)) {
              : 			/* Send to whoever sent to us */
              : 			if (ast_sockaddr_cmp(&rtp->rtcp->them, addr)) {
              : 				ast_sockaddr_copy(&rtp->rtcp->them, addr);
              : 				if (rtpdebug) {
              : 					ast_debug(0, "RTCP NAT: Got RTCP from other end. Now sending to address %s\n",
              : 						ast_sockaddr_stringify(&rtp->rtcp->them));
              : 				}
              : 			}
              : 		}
This is loop invariant code.



-- 
To view, visit https://gerrit.asterisk.org/6443
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d89e3c27db83efa0e6b52734f73c88ac2939e2
Gerrit-Change-Number: 6443
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 07 Sep 2017 19:47:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170907/1c256f48/attachment-0001.html>