[Asterisk-code-review] stasis/control.c: Fix set interval hook() ref leak. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Thu Sep 7 10:46:43 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6440 )

Change subject: stasis/control.c: Fix set_interval_hook() ref leak.
......................................................................

stasis/control.c: Fix set_interval_hook() ref leak.

Change-Id: Ia0edb7dc0dbbb879c079ff7000f1b722d86ce7dc
---
M res/stasis/control.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/res/stasis/control.c b/res/stasis/control.c
index 503f111..7356fe8 100644
--- a/res/stasis/control.c
+++ b/res/stasis/control.c
@@ -1133,10 +1133,12 @@
 
 	if (ast_bridge_interval_hook(bridge_channel->features, 0, ms > 0 ? ms : 1,
 			bridge_timeout, NULL, NULL, 0)) {
+		ao2_ref(bridge_channel, -1);
 		return;
 	}
 
 	ast_queue_frame(bridge_channel->chan, &ast_null_frame);
+	ao2_ref(bridge_channel, -1);
 }
 
 int control_swap_channel_in_bridge(struct stasis_app_control *control, struct ast_bridge *bridge, struct ast_channel *chan, struct ast_channel *swap)

-- 
To view, visit https://gerrit.asterisk.org/6440
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0edb7dc0dbbb879c079ff7000f1b722d86ce7dc
Gerrit-Change-Number: 6440
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170907/341d442b/attachment.html>


More information about the asterisk-code-review mailing list