[Asterisk-code-review] chan sip: when getting sip pvt return failure if not found (asterisk[14])

[Scott Griepentrog]

Scott Griepentrog has uploaded this change for review. ( https://gerrit.asterisk.org/6454


Change subject: chan_sip: when getting sip pvt return failure if not found
......................................................................

chan_sip: when getting sip pvt return failure if not found

In handle_request_invite, when processing a pickup, a call
is made to get_sip_pvt_from_replaces to locate the pvt for
the subscription. The pvt is assumed to be valid when zero
is returned indicating no error, and is dereferenced which
can cause a crash if it was not found.

This change checks the not found case and returns -1 which
allows the calling code to fail appropriately.

ASTERISK-27217 #close
Reported-by: Bryan Walters

Change-Id: I6bee92b8b8b85fcac3fd66f8c00ab18bc1765612
---
M channels/chan_sip.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/54/6454/1

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index cd5cc0c..89e1e3d 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -18625,6 +18625,11 @@
 		}
 	}
 
+	if (!sip_pvt_ptr) {
+		/* return error if sip_pvt was not found */
+		return -1;
+	}
+
 	/* If we're here sip_pvt_ptr has been copied to *out_pvt, prevent RAII_VAR cleanup */
 	sip_pvt_ptr = NULL;
 

-- 
To view, visit https://gerrit.asterisk.org/6454
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bee92b8b8b85fcac3fd66f8c00ab18bc1765612
Gerrit-Change-Number: 6454
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Griepentrog <scott at griepentrog.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170906/d8e56025/attachment.html>