[Asterisk-code-review] res srtp: Add support for libsrtp2.1. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/6418 )

Change subject: res_srtp: Add support for libsrtp2.1.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6418/1/res/srtp/srtp_compat.h
File res/srtp/srtp_compat.h:

https://gerrit.asterisk.org/#/c/6418/1/res/srtp/srtp_compat.h@8
PS1, Line 8: #if defined(SRTP_AES_ICM_128)
           : #define AES_128_ICM SRTP_AES_ICM_128
           : #else
           : #define AES_128_ICM SRTP_AES_ICM
           : #endif
           : #define HMAC_SHA1 SRTP_HMAC_SHA1
> Why the difference here versus the rest?
In Asterisk 13, these two macros (HMAC_SHA1 and AES_128_ICM) are actually used.

Since Asterisk 14, these macros are not used anymore† because crypto policies are used instead (crypto_policy_set_aes_cm_128_hmac_sha1). In libSRTP, these policies were added 12 years ago. Therefore, Asterisk 14 requires libSRTP 1.4.2 (May 2006) or newer. Asterisk 13 can be used with even earlier libSRTP versions.

† happened as side effect of ASTERISK-26190, which was Asterisk 14+ only.



-- 
To view, visit https://gerrit.asterisk.org/6418
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6eb3c3bc844fee8a624060a2eb6f182dc70315
Gerrit-Change-Number: 6418
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 06 Sep 2017 21:02:28 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170906/190f26ed/attachment.html>