[Asterisk-code-review] res pjsip t38: Make t38 reinvite response cb tolerant of NU... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6384 )

Change subject: res_pjsip_t38:  Make t38_reinvite_response_cb tolerant of NULL channel
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6384/1/res/res_pjsip_t38.c
File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/#/c/6384/1/res/res_pjsip_t38.c@307
PS1, Line 307: 		ao2_cleanup(session_media);
This is incorrect. session_media is now uninitialized so it can point to something incorrect, it's also not possible for it to be legit non-NULL here.



-- 
To view, visit https://gerrit.asterisk.org/6384
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I4326e288d36327f6c79ab52226d54905cdc87dc7
Gerrit-Change-Number: 6384
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 05 Sep 2017 10:36:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170905/ceb61dcc/attachment.html>