[Asterisk-code-review] res ari channels: Fix reference leak in channel state invalid. (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6944 )

Change subject: res_ari_channels: Fix reference leak in channel_state_invalid.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6944/1/res/ari/resource_channels.c
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/6944/1/res/ari/resource_channels.c@102
PS1, Line 102: 		ao2_cleanup(snapshot);
Any reason you used ao2_cleanup here instead of ao2_ref? It's guaranteed to be non-NULL.



-- 
To view, visit https://gerrit.asterisk.org/6944
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c653f00416b39978513c5605c4be0f03b1df29a
Gerrit-Change-Number: 6944
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 31 Oct 2017 18:29:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171031/225f3922/attachment.html>