[Asterisk-code-review] alembic: Add bundle column in ps endpoints table (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Oct 30 11:56:57 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/6904 )

Change subject: alembic: Add bundle column in ps_endpoints table
......................................................................

alembic: Add bundle column in ps_endpoints table

The ps_endpoints table was missing the bundle column
introduced with the bundle feature in
commit 065c3005ad92.

ASTERISK-27374 #close

Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46
---
A contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py
1 file changed, 34 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py b/contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py
new file mode 100644
index 0000000..57b5688
--- /dev/null
+++ b/contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py
@@ -0,0 +1,34 @@
+"""add bundle to ps_endpoints
+
+Revision ID: de83fac997e2
+Revises: 20abce6d1e3c
+Create Date: 2017-10-24 17:10:57.242020
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = 'de83fac997e2'
+down_revision = '20abce6d1e3c'
+
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects.postgresql import ENUM
+
+YESNO_NAME = 'yesno_values'
+YESNO_VALUES = ['yes', 'no']
+
+def upgrade():
+     ############################# Enums ##############################
+
+    # yesno_values have already been created, so use postgres enum object
+    # type to get around "already created" issue - works okay with mysql
+    yesno_values = ENUM(*YESNO_VALUES, name=YESNO_NAME, create_type=False)
+
+    op.add_column('ps_endpoints', sa.Column('bundle', yesno_values))
+
+def downgrade():
+    context = op.get_context()
+
+    if context.bind.dialect.name == 'mssql':
+        op.drop_constraint('ck_ps_endpoints_bundle_yesno_values', 'ps_endpoints')
+    op.drop_column('ps_endpoints', 'bundle')

-- 
To view, visit https://gerrit.asterisk.org/6904
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46
Gerrit-Change-Number: 6904
Gerrit-PatchSet: 5
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171030/70fabf21/attachment.html>


More information about the asterisk-code-review mailing list