[Asterisk-code-review] dtls: Add support for ephemeral DTLS certificates. (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6640 )

Change subject: dtls: Add support for ephemeral DTLS certificates.
......................................................................


Patch Set 9:

> > If no cert file is specified, automatically generating an
 > ephemeral
 > > cert even if dtls_auto_generate_cert = no technically changes
 > > current default behavior.  You might as well not have an option
 > at
 > > all.  If you specify a cert file, it gets used, if not, an
 > > ephemeral one is generated.   Or did I miss something?
 > 
 > That should only happen when webrtc is set to true. Where are you
 > looking?

Yeah ok, it's insode the "if webrtc" block in sip_endpoint_apply_handler.  How about adding note to both the webrtc and dtls_auto_generate_cert option docs then.


-- 
To view, visit https://gerrit.asterisk.org/6640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4
Gerrit-Change-Number: 6640
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 30 Oct 2017 16:21:35 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171030/df38b69a/attachment.html>