[Asterisk-code-review] core / pjsip: Add support for grouping streams together. (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6936 )

Change subject: core / pjsip: Add support for grouping streams together.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/6936/1/main/stream.c
File main/stream.c:

https://gerrit.asterisk.org/#/c/6936/1/main/stream.c@578
PS1, Line 578: 	return stream->group;
how about adding ast_assert(stream != NULL); to be consistent with other getters/setters.


https://gerrit.asterisk.org/#/c/6936/1/main/stream.c@583
PS1, Line 583: 	stream->group = group;
same


https://gerrit.asterisk.org/#/c/6936/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6936/1/res/res_pjsip_session.c@580
PS1, Line 580: 	               
inconsistent whitespace


https://gerrit.asterisk.org/#/c/6936/1/res/res_pjsip_session.c@596
PS1, Line 596:                 }
same



-- 
To view, visit https://gerrit.asterisk.org/6936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad
Gerrit-Change-Number: 6936
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 30 Oct 2017 14:21:21 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171030/0956721c/attachment.html>