[Asterisk-code-review] Add support for delayed shutdown of Asterisk when checking f... (testsuite[master])

George Joseph asteriskteam at digium.com
Mon Oct 30 08:51:38 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6845 )

Change subject: Add support for delayed shutdown of Asterisk when checking for leaks.
......................................................................


Patch Set 3: Code-Review-1

I'm not a real fan of having to add a parameter to every test's yaml.  How about making this a command line option that automatically adds 
'n' amount to very reactor timeout?

--reactor-timeout-adjustment=5 to add 5 seconds, or if you have a really fast machine,  --reactor-timeout-adjustment=-5 to reduce the timeout by 5 seconds.


-- 
To view, visit https://gerrit.asterisk.org/6845
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec89e4a116526ad34796a233e15fec794cf3e1
Gerrit-Change-Number: 6845
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 30 Oct 2017 13:51:38 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171030/02bbc7be/attachment.html>


More information about the asterisk-code-review mailing list