[Asterisk-code-review] logger: Always run rotate file on huge log files. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6861 )

Change subject: logger: Always run rotate_file on huge log files.
......................................................................


Patch Set 1:

> For someone who has strategy set to NONE or just defaults, will
 > this change any behavior?  Do we need something in CHANGES?

On further investigation I think this patch is unneeded.  I was concerned about configs with:
rotatestrategy=none
exec_after_rotate=logrotate --force ${filename}

We would not automatically initiate external logrotate when the log file grows above 1gb.  But this amount is arbitrary and doesn't necessarily mean anything.  SIGXFSZ is what really matters, and in response to SIGXFSZ we ultimately call reload_logger(-1, NULL).  In this case we don't need to check the size of the file in question, we'll end up calling rotate_file on all file based channels.

Going to abandon this, thanks for looking.


-- 
To view, visit https://gerrit.asterisk.org/6861
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3633c24242b88da9daa1d2217dcde0b302e03653
Gerrit-Change-Number: 6861
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 23 Oct 2017 17:14:03 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171023/5153dc3e/attachment.html>