[Asterisk-code-review] res pjsip pubsub: Clear self-reference on terminated subscri... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6857 )

Change subject: res_pjsip_pubsub: Clear self-reference on terminated subscription tree.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6857/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/6857/1/res/res_pjsip_pubsub.c@3683
PS1, Line 3683: 	if (sub_tree->root) {
              : 		ast_sip_subscription_destroy(sub_tree->root);
              : 	}
I think before this is done we need to document the specific lifetime and reference count management of this both for future reference and also to ensure that this is the correct course of action.



-- 
To view, visit https://gerrit.asterisk.org/6857
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7baddee3c16dfdc5a12fa652c5359de465e9ebbf
Gerrit-Change-Number: 6857
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 23 Oct 2017 14:25:20 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171023/500b061f/attachment.html>