[Asterisk-code-review] This patch adds a beanstalk CDR backend. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6819 )

Change subject: This patch adds a beanstalk CDR backend.
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6819/10/cdr/cdr_beanstalkd.c
File cdr/cdr_beanstalkd.c:

https://gerrit.asterisk.org/#/c/6819/10/cdr/cdr_beanstalkd.c@117
PS10, Line 117: 	bs_host = ast_strdup(EFAULT_BEANSTALK_HOST);
You lost the 'D' in DEFAULT, so I suspect this module will fail to compile as is.  I think jenkins doesn't have the beanstalk-client library so it's not attempting to compile this module.  When you test compile make sure you use '--enable-dev-mode' configure option.

Ultimately it is up to you to compile this module and test that it does something reasonable when run.



-- 
To view, visit https://gerrit.asterisk.org/6819
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe4089a34ab3b39230786d9bbfddafa56715f48
Gerrit-Change-Number: 6819
Gerrit-PatchSet: 10
Gerrit-Owner: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 18 Oct 2017 14:30:33 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171018/c3f28ebc/attachment.html>