[Asterisk-code-review] This patch adds a beanstalk CDR backend. (asterisk[master])

[Nir Simionovich (GreenfieldTech - Israel)]

Nir Simionovich (GreenfieldTech - Israel) has posted comments on this change. ( https://gerrit.asterisk.org/6819 )

Change subject: This patch adds a beanstalk CDR backend.
......................................................................


Patch Set 1:

> I raised this review on IRC, it was asked: why not just tail the
 > cdr.csv file, transform, and put it into beanstalk?  I have no
 > opinion on this, just sharing a question that was asked.

Well, that is indeed doable, however, is prone to failures and worst of all, 
add another moving part to the system. If there is one thing I've learned 
over time, when building large scale systems, if I can reduce the number
of moving parts in the system - the easier it is to debug, the easier it is ?
to maintain.

 > I believe this is a comprehensive review of technical issues with
 > the current patch.  If you haven't already please take a look at
 > the wiki [1] for instructions on updating this review (instead of
 > abandoning and creating a new one).
 > 
 > [1] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage#GerritUsage-UpdatingaReview

I'll work the technical issues detailed below, I noticed that some of them 
are related to me basing my work on the cdr_manager.c module, which is 
most probably why I have some left overs in there.


-- 
To view, visit https://gerrit.asterisk.org/6819
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe4089a34ab3b39230786d9bbfddafa56715f48
Gerrit-Change-Number: 6819
Gerrit-PatchSet: 1
Gerrit-Owner: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Comment-Date: Tue, 17 Oct 2017 18:16:28 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171017/dac9cad7/attachment.html>