[Asterisk-code-review] This patch adds a beanstalk CDR backend. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6818 )

Change subject: This patch adds a beanstalk CDR backend.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Something weird is going on with this review.

This is turning into a patch series chronicling changes for a single patch review.  You need to rebase your local branch and SQUASH the commits to a single commit being mindful of the Change-Id.

I think you should keep the change-id in this review and abandon the other reviews as they are intermediate commits.

https://gerrit.asterisk.org/#/c/6818/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/6818/1//COMMIT_MSG@19
PS1, Line 19: Change-Id: I44e7eb208f19520e939d3fcab403f4ec20370b61
You don't want to have different change id's for a patch you are submitting for review.  Gerrit uses the change-id to know what review you are working with.  A different change id is a different review.  Fixing a patch to incorporate feedback for a review MUST not get a new change id.

[1] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage



-- 
To view, visit https://gerrit.asterisk.org/6818
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e7eb208f19520e939d3fcab403f4ec20370b61
Gerrit-Change-Number: 6818
Gerrit-PatchSet: 1
Gerrit-Owner: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 21:03:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171016/3406ea98/attachment.html>